Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Cake support #958

Closed
wants to merge 1 commit into from
Closed

[WIP] Add Cake support #958

wants to merge 1 commit into from

Conversation

gitfool
Copy link

@gitfool gitfool commented Jan 24, 2019

Trying to get the ball rolling for #733. I'm struggling though as my Ruby skillz are rusty and there's a lot to grok. After looking around the repo, I've at least formed what I think is the required file fetcher and file parser. This much should be fairly straight forward; maybe the maintainers can easily take it over the line from here? 😛

  • file fetcher simply looks for *.cake files
  • file parser uses regexes to match the permutations of Cake preprocessor directives
    • and simply extracts the package and version to pass to the NuGet package manager

I'm a little lost from here but the key is that Cake is using NuGet for dependencies, so almost everything else the implementation needs should somehow delegate to the NuGet package manager.

Notes:

  • NuGet "source" URL can optionally be specified in the preprocessor directive but I didn't know exactly how to specify that to the NuGet package manager. I'm sure Dependabot handles this though as it picks up changes to packages in private myget feeds, that I specify in NuGet.config only.

@gitfool
Copy link
Author

gitfool commented Jan 24, 2019

Excuse me while I use your CI to check things. RuboCop is slapping me. 😊

@greysteil
Copy link
Contributor

Nice! I'm crunched with a couple of other things - is it OK if I look over this late next week? Apologies for the slow turn-around!

@gitfool
Copy link
Author

gitfool commented Jan 24, 2019

@greysteil of course; no problemo! 😄

I've rebased this PR onto the latest master with the fix re invalid file names on Windows. Thanks for that!

@gep13
Copy link

gep13 commented Apr 24, 2019

@greysteil @gitfool just wanted to touch base on this...

What is this status of this?

@gitfool
Copy link
Author

gitfool commented May 12, 2019

@gep13 I'm just going to leave this as is until @greysteil can look at it. 🤞

@ChrisMaddock
Copy link

Just stumbled across this - it will be great for us at NUnit! Thanks guys! 😄

@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 23, 2019
@gitfool
Copy link
Author

gitfool commented Oct 23, 2019

@greysteil how do I keep this PR on life support?

@stale stale bot removed the wontfix label Oct 23, 2019
@greysteil
Copy link
Contributor

I'm not on the Dependabot team anymore (I work on security more generally at GitHub) but I think stalebot works based ono comments on an issue. I don't know if it's possible to disable it for a PR - whoever turned it no should know more.

@gep13
Copy link

gep13 commented Oct 23, 2019

@greysteil thanks for replying back about this. Congratulations on the new assignment, hope it is going well for you. Do you know who is assigned to look at new dependabot features? It would still be great to get this looked at, and hopefully merged in.

@greysteil
Copy link
Contributor

@feelepxyz and @hmarr are your go-tos there, along with @jeffmcaffer.

@rebelagentm
Copy link
Contributor

@gitfool @gep13 We set up Stale to help us manage our backlog. I'm going through issues and will be keeping requests like this open. For features that have been requested more than once, there may be a single tracking issue opened, but your issue will be referenced in it if that is the case. Sorry for any confusion!

@rebelagentm rebelagentm added cake T: feature-request Requests for new features labels Oct 23, 2019
@MO2k4
Copy link

MO2k4 commented Jan 2, 2020

Hi,

is there any chance to fix the merge conflicts and merge this pr? I would be happy to use this feature :-)

Best Regards,
Martin

@Jacob-Morgan Jacob-Morgan mentioned this pull request May 8, 2020
6 tasks
@feelepxyz feelepxyz changed the base branch from master to main June 24, 2020 11:28
@gitfool gitfool closed this Jun 29, 2020
@gitfool gitfool deleted the add-cake-support branch June 29, 2020 02:16
@gitfool
Copy link
Author

gitfool commented Jun 29, 2020

Superseded by #1848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature-request Requests for new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants